Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon test from realfavicongenerator.net #1670

Closed
ghost opened this issue Feb 10, 2015 · 2 comments
Closed

Favicon test from realfavicongenerator.net #1670

ghost opened this issue Feb 10, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 10, 2015

Is this an issue of concern?
http://realfavicongenerator.net/favicon_checker?site=http%3A%2F%2Fhtml5boilerplate.com%2F&ignore_root_issues=on#.VNp8ZcY0XP4

@alrra
Copy link
Member

alrra commented Feb 11, 2015

@ahite-archermalmo Please open future issues regarding https://html5boilerplate.com/ in the https://github.com/h5bp/html5boilerplate.com repository. Thanks!

As for some of the issues:

iOS Favicon

Some iOS pictures are not declared

114x114 picture
72x72 picture
144x144 picture
60x60 picture
120x120 picture
76x76 picture
152x152 picture
180x180 picture

You don't need to have all of them, see: #1367.

iOS Favicon

Some iOS pictures are not declared:
...
180x180 picture

A 180x180 picture is defined, see: https://html5boilerplate.com/apple-touch-icon.png.

Bakground color for Windows 8 tile is not defined. Windows will choose it for you, which is probably not what you want.

We don't use a tile image that has transparent parts, so specifying the color doesn't do anything for our particular case (see also: #1481).

As for some of the other issues, we do not include those icons due to the low usage in regard to out particular site.

We should however include a web application manifest file.

@ArmorDarks
Copy link

Btw, worth to review report once again, since it is different now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@alrra @ArmorDarks and others