Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions/Release Test and fine-tune the release #2258

Closed
3 tasks done
roblarsen opened this issue Jun 3, 2020 · 5 comments
Closed
3 tasks done

Actions/Release Test and fine-tune the release #2258

roblarsen opened this issue Jun 3, 2020 · 5 comments
Assignees
Milestone

Comments

@roblarsen
Copy link
Member

roblarsen commented Jun 3, 2020

I'm tired, so I'm just capturing a to-do list to vet the release process tomorrow. It works from end to end.

  • I created an annotated tag on the command line (See below, I forgot the
  • I pushed the tag.
  • The action caught the new tag, zipped up the dist folder and attached it to a newly created GitHub release.
  • The action also published the package to npm.

All of that worked. I think I will need to update the formatting of the release annotation, but otherwise it's all pretty good.

Open issues to clean up before Thursday/Monday (I'm aiming to release on Thursday, but will push it out to Monday if the blog post takes longer than I'm hoping.)

  • Change the file name of the zip file to match previous versions. I forgot the html5-boilerplate_ bit.
  • Figure out how to zip the dist folder without including the folder itself. Right now the folder contains the dist folder as a single child. We usually just have it be the contents of the dist folder. My brain will hurt after this, I think. Maintaining a project like this means I have to learn about a lot of stuff. Learning the complexities of the zip command is not the most exciting stuff I've ever had to tackle. If anyone wants to explain this to me like I've five, I'm all ears.
  • Test the npm package via all the different methods (including the new npx command)

image

@roblarsen roblarsen added this to the 8.0 milestone Jun 3, 2020
@roblarsen roblarsen self-assigned this Jun 3, 2020
@Jeroen-Matthijssens
Copy link

Jeroen-Matthijssens commented Jun 3, 2020

Instead of trying to figure out how to trick zip into dropping the top level directory you could use the working-directory directive on the step and zip everything.

- name: Create Zip Folder
  working-directory: ./dist
  run: zip -r ../${{ steps.get_version.outputs.VERSION }}.zip .

Just a thought.

@roblarsen
Copy link
Member Author

@Jeroen-Matthijssens that is much more appealing

@roblarsen
Copy link
Member Author

@Jeroen-Matthijssens that was the way to go. Thanks for the fresh set of eyes and good idea.

@Jeroen-Matthijssens
Copy link

@roblarsen np, I've been following the project for a long time, but only recently I have tried to actually participate and be helpful. Glad I could contribute in some way :)

@roblarsen
Copy link
Member Author

closed via #2260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants