Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE hr element alignment #297

Closed
wants to merge 1 commit into from
Closed

IE hr element alignment #297

wants to merge 1 commit into from

Conversation

danielstocks
Copy link

Test Case: http://www.hixie.ch/tests/evil/mixed/hrbrstyles.html

Edit the second example (in webkit for example), set inline style: margin: 1em 0 (like in the boilerplate css), now give it a width of 100px. It will align left.

If you do the same thing in IE(7,8, yet to test IE6) it will align center, because it uses text-align internally rather than margin (as should be according to the HTML5 spec) . Adding text-align: left fixes this.


http://www.w3.org/TR/html5/rendering.html#the-hr-element-0

…et this in order to comply with margin:1em 0
@danielstocks
Copy link
Author

So is this a no go then?

@nimbupani
Copy link
Member

I have added this in the Make it better section so people can refer to it. I do not think hr is used as extensively to deserve a universal style reset.

@devinrhode2
Copy link
Contributor

Why is this not in main.css today?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants