From bc3e42b77736e0c0851fd9fbdc0d4fe129efeab9 Mon Sep 17 00:00:00 2001 From: farisachugthai Date: Thu, 5 Nov 2020 11:30:10 -0500 Subject: [PATCH] Remove a few more unused imports Trailing whitespace in a few lines --- tests/test_config_manager.py | 2 -- tests/test_files.py | 2 +- tests/test_serverapp.py | 20 +++++++------------- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/tests/test_config_manager.py b/tests/test_config_manager.py index 4384f69999..41280939bf 100644 --- a/tests/test_config_manager.py +++ b/tests/test_config_manager.py @@ -1,7 +1,5 @@ import json import os -import shutil -import tempfile from jupyter_server.config_manager import BaseJSONConfigManager diff --git a/tests/test_files.py b/tests/test_files.py index e65dc2da93..56f8506ccb 100644 --- a/tests/test_files.py +++ b/tests/test_files.py @@ -171,4 +171,4 @@ async def test_old_files_redirect(fetch, serverapp, root_dir): # r = self.request('GET', 'files/test.txt?download=1') # disposition = r.headers.get('Content-Disposition', '') # self.assertIn('attachment', disposition) - # self.assertIn("filename*=utf-8''test.txt", disposition) \ No newline at end of file + # self.assertIn("filename*=utf-8''test.txt", disposition) diff --git a/tests/test_serverapp.py b/tests/test_serverapp.py index 8b1ed09bd3..664afdbe59 100644 --- a/tests/test_serverapp.py +++ b/tests/test_serverapp.py @@ -1,21 +1,15 @@ - import os import getpass -import pathlib import pytest import logging - from unittest.mock import patch - from traitlets import TraitError from traitlets.tests.utils import check_help_all_output - from jupyter_core.application import NoStart - from jupyter_server.serverapp import ( - ServerApp, + ServerApp, list_running_servers, JupyterPasswordApp, JupyterServerStopApp @@ -35,12 +29,12 @@ def test_server_info_file(tmp_path, configurable_serverapp): servers = list(list_running_servers(app.runtime_dir)) assert len(servers) == 1 - sinfo = servers[0] - + sinfo = servers[0] + assert sinfo['port'] == app.port assert sinfo['url'] == app.connection_url assert sinfo['version'] == app.version - + app.remove_server_info_file() assert list(list_running_servers(app.runtime_dir)) == [] @@ -62,7 +56,7 @@ def test_root_dir(tmp_path, configurable_serverapp): ) def invalid_root_dir(tmp_path, request): path = tmp_path.joinpath(*request.param) - # If the path is a file, create it. + # If the path is a file, create it. if os.path.splitext(str(path))[1] != '': path.write_text('') return str(path) @@ -90,10 +84,10 @@ def valid_root_dir(tmp_path, request): def test_valid_root_dir(valid_root_dir, configurable_serverapp): app = configurable_serverapp(root_dir=valid_root_dir) root_dir = valid_root_dir - # If nested path, the last slash should + # If nested path, the last slash should # be stripped by the root_dir trait. if root_dir != '/': - root_dir = valid_root_dir.rstrip('/') + root_dir = valid_root_dir.rstrip('/') assert app.root_dir == root_dir