Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B1 mapping improvements #41

Merged
merged 28 commits into from
Nov 28, 2022
Merged

B1 mapping improvements #41

merged 28 commits into from
Nov 28, 2022

Conversation

lukeje
Copy link
Member

@lukeje lukeje commented Mar 8, 2022

Merge the implementation of (S)DAM B1 mapping from @tleutritz-cbs into the toolbox. Also includes a bugfix for a bug that can occur if filename lengths of the B1 input files are not equal.

@lukeje lukeje changed the title Implements (S)DAM B1 mapping Implement (S)DAM B1 mapping Mar 8, 2022
@lukeje lukeje linked an issue Mar 8, 2022 that may be closed by this pull request
@lukeje lukeje added the enhancement New feature or request label Mar 8, 2022
@lukeje
Copy link
Member Author

lukeje commented Mar 10, 2022

@kerrinpine: I've made the change that AFI (and DAM) no longer uses "abs" to get rid of the imaginary component, but rather uses "real" instead. In cases where AFI or DAM images are input in the wrong order, this now results in a large hole in the centre of the B1 map, rather than "reasonable" looking incorrect values. Hopefully this obvious error will cause people to check their input data, rather than allowing the erroneous B1 maps to propagate down the processing chain.

Unfortunately I could not find a simple robust criterion to warn if too many complex results are returned, as background voxels are expected to show a significant number of erroneous values, and the number of background voxels in a volume can be very large.

I will include these changes in our Leipzig toolbox as soon as this pull request is finalised here.

…ction can now read information in the nifti decription field and warns if fa1!=2xfa2.
@lukeje
Copy link
Member Author

lukeje commented Mar 11, 2022

Unfortunately I could not find a simple robust criterion to warn if too many complex results are returned, as background voxels are expected to show a significant number of erroneous values, and the number of background voxels in a volume can be very large.

Realised that comparing the result between the two possible orderings works for AFI (but not DAM).

@lukeje lukeje changed the title Implement (S)DAM B1 mapping Implement (S)DAM B1 mapping and improve B1 input checking Jul 20, 2022
Luke Edwards added 6 commits July 29, 2022 09:03
… B1 mapping calculation. This is mainly useful at ultrahigh field, where B1 inhomogeneity may cause actual flip angles to be above 180deg.
…id (e.g. MPI-CBS SE TE is longer than STE TE in DICOMs)
@lukeje
Copy link
Member Author

lukeje commented Oct 17, 2022

TODOs:

  • add smoothing option to pre-processed B1 (request from @mfcallaghan)
  • more testing that changing 3D-EPI-SE/STE algorithm does not cause significant changes (request from @antoinelutti)
  • document expected order of 3D-EPI-SE/STE input if input-checking is disabled (request from @nbeliy)
  • add switch to read 3D-EPI-SE/STE flip angles from json metadata (request from @nbeliy)

@lukeje lukeje changed the title Implement (S)DAM B1 mapping and improve B1 input checking B1 mapping improvements Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant