Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repetition time stored in BIDS AFI B1-mapping sidecar file #62

Merged
merged 10 commits into from
Jun 26, 2023

Conversation

lukeje
Copy link
Member

@lukeje lukeje commented Jan 31, 2023

Added support for BIDS-ified data which specifies separate RepetitionTimes in the sidecar metadata of each AFI volume.

The toolbox was written based on data where (because of sequence restrictions) the RepetitionTime metadata fields were always the same for the two separate AFI volumes, which were really recorded with two different RepetitionTimes. The legacy solution to this was to read the RepetitionTimes from a Siemens DICOM field (alTR), which is preserved if the hMRI toolbox conversion is used.

Under the assumption that BIDS will drive solutions to enable saving two separate RepetitionTimes (either in the sequence or during the DICOM to NIfTI conversion), the toolbox now checks whether the two TRs are different, and if they are, uses them rather than the legacy method.

Backwards compatibility warning

This pull request will break backwards compatibility with some scripts. It requires the input AFI data to be given in the opposite order to previously when using the legacy method. Note that this new order is more logical and matches the order of RepetitionTimes in the alTR array.

Following a previous pull request, a warning should be printed if the toolbox detects that reversing the data order would improve the quality of the B1 map.

If the data are BIDS-compliant and specify a different RepetitionTime in each sidecar file, then the order will not matter.

ledwards and others added 2 commits January 31, 2023 16:52
Warning: this also requires giving the input AFI data
in the opposite order for the legacy method (the order
is now more logical and matches the order of TRs in the
alTR array)
@lukeje lukeje added the enhancement New feature or request label Jun 2, 2023
@lukeje lukeje merged commit 56cee35 into master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant