Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar disappear after typing #940

Closed
bestv2 opened this issue Aug 23, 2017 · 9 comments
Closed

Toolbar disappear after typing #940

bestv2 opened this issue Aug 23, 2017 · 9 comments

Comments

@bestv2
Copy link

bestv2 commented Aug 23, 2017

The top toolbar disappear after i type any thing in react native.
image
after i type '1' the toolbar disappear
image

@bestv2 bestv2 changed the title tool bar disappear after typing Toolbar disappear after typing Aug 23, 2017
@hackiftekhar
Copy link
Owner

Are you changing the inputAccessoryView when typing?

@bestv2
Copy link
Author

bestv2 commented Aug 24, 2017

I did nothing,just use React-native's InputItem

@hackiftekhar
Copy link
Owner

hackiftekhar commented Aug 24, 2017

Sorry since I don't have any experience with react-native so I'm unable to help you on this. Can you take help from any react guy and point out the error, if it's due to my library I would be happy to fix it.

@bestv2
Copy link
Author

bestv2 commented Aug 28, 2017

@hackiftekhar thanks for your reply, i will close the issue and then try to find the reason. if it's due to your library,i will reopen it with detail description.

@bestv2 bestv2 closed this as completed Aug 28, 2017
@douglasjunior
Copy link
Contributor

@hackiftekhar Have you seen this problem in any previous situation? We're discussing this here douglasjunior/react-native-keyboard-manager#3

Something has changed in the latest versions of React Native and is causing this problem.

Every help is welcome.

@douglasjunior
Copy link
Contributor

douglasjunior commented Sep 1, 2017

This is the Log displayed when input focus:

2017-09-01 10:12:10.585 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** textFieldViewDidBeginEditing: started ******
2017-09-01 10:12:10.586 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** addToolbarIfRequired started ******
2017-09-01 10:12:10.587 SampleKeyboardManager[10100:66666] IQKeyboardManager: Found 7 responder sibling(s)
2017-09-01 10:12:10.594 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** addToolbarIfRequired ended: 0.00768353 seconds ******
2017-09-01 10:12:10.596 SampleKeyboardManager[10100:66666] IQKeyboardManager: Saving <UIViewController 0x7ff67ad0e0d0> beginning Frame: {{0, 0}, {375, 667}}
2017-09-01 10:12:10.597 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** textFieldViewDidBeginEditing: ended: 0.0116473 seconds ******
2017-09-01 10:12:10.649393-0300 SampleKeyboardManager[10100:66776] [] nw_connection_get_connected_socket_block_invoke 8 Connection has no connected handler
2017-09-01 10:12:10.790200-0300 SampleKeyboardManager[10100:66666] [MC] System group container for systemgroup.com.apple.configurationprofiles path is /Users/douglas/Library/Developer/CoreSimulator/Devices/D05DCF79-B22F-4D22-B047-2825A1A68430/data/Containers/Shared/SystemGroup/systemgroup.com.apple.configurationprofiles
2017-09-01 10:12:10.824886-0300 SampleKeyboardManager[10100:66666] [MC] Reading from private effective user settings.
2017-09-01 10:12:11.175 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardWillShow: started ******
2017-09-01 10:12:11.176 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** adjustFrame started ******
2017-09-01 10:12:11.176 SampleKeyboardManager[10100:66666] IQKeyboardManager: Need to move: -181.00
2017-09-01 10:12:11.177 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** adjustFrame ended: 0.0013578 seconds ******
2017-09-01 10:12:11.178 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardWillShow: ended: 0.00248744 seconds ******
2017-09-01 10:12:12.272 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardDidShow: started ******
2017-09-01 10:12:12.274 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardDidShow: ended: 0.00118494 seconds ******

When start typing.

2017-09-01 10:12:22.713 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardWillShow: started ******
2017-09-01 10:12:22.714 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** adjustFrame started ******
2017-09-01 10:12:22.715 SampleKeyboardManager[10100:66666] IQKeyboardManager: Need to move: -225.00
2017-09-01 10:12:22.715 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** adjustFrame ended: 0.00121533 seconds ******
2017-09-01 10:12:22.716 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardWillShow: ended: 0.00258085 seconds ******
2017-09-01 10:12:22.724 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardDidShow: started ******
2017-09-01 10:12:22.724 SampleKeyboardManager[10100:66666] IQKeyboardManager: ****** keyboardDidShow: ended: 0.00054852 seconds ******

@douglasjunior
Copy link
Contributor

Thanks to @NicholasBertazzon, we found that the problem came from the commit facebook/react-native@2b1795c

Like @hackiftekhar has suggested in your comment, the inputAccessoryView is changed.

Is there anything we can do?

douglasjunior referenced this issue in facebook/react-native Sep 1, 2017
…n iOS

Summary:
Standard only-numeric (number pad) keyboard on iOS does not have any "Done" or "Enter" button, and this is often very badly hurt user experience.
Usually it can be solved by implementing custom `inputAccessoryView`, but RN does not have built-in support for customizing it.
So, this commit introduced limited support only for "Done" button (returnKeyType="done") and it should suite very well for the vast majority of use cases.
This is highly requested feature, see more details here:
#1190

Reviewed By: mmmulani

Differential Revision: D5268020

fbshipit-source-id: 90bd5bffac6aaa1fb7c5c2ac539b35b04d45918f
@hackiftekhar
Copy link
Owner

Okay, so it looks to be due to other libraries

@douglasjunior
Copy link
Contributor

Yes, React Native provides its own TextInput implementation.

I'll try to fix and send a Pull Request to React Native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants