Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serialization] Deserializer should create default ImageParams (if external_params is empty) #7862

Open
derek-gerstmann opened this issue Sep 22, 2023 · 1 comment
Assignees

Comments

@derek-gerstmann
Copy link
Contributor

    // FIXME: We shouldn't have to populate the params ... but passing an empty map triggers an error in deserialize
    // for a missing input param
    std::map<std::string, Parameter> params; 
    ImageParam input(UInt(8), 3, "input");
    params.insert({"input", input.parameter()});

    // Now deserialize the pipeline from file
    Pipeline blur_pipeline = deserialize_pipeline("blur.hlpipe", params);
@TH3CHARLie
Copy link
Contributor

I think I already had a fix for this locally, let me send a PR on Monday

@TH3CHARLie TH3CHARLie self-assigned this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants