Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: semver supports asterisk in range indicator #1438

Merged
merged 1 commit into from
Oct 27, 2020
Merged

fix: semver supports asterisk in range indicator #1438

merged 1 commit into from
Oct 27, 2020

Conversation

ml019
Copy link
Contributor

@ml019 ml019 commented Oct 27, 2020

Description

Add support for the asterisk character as a substitute for 0.

Motivation and Context

Better aligns semver support to the equivalent node library.

How Has This Been Tested?

Local testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@ml019 ml019 requested a review from a team October 27, 2020 05:22
@roleyfoley roleyfoley merged commit 8b11697 into hamlet-io:master Oct 27, 2020
@ml019 ml019 deleted the fix-semver-utilities branch October 28, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roleyfoley roleyfoley roleyfoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ml019 @roleyfoley