Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): get metric dimensions from blueprint #1490

Merged
merged 2 commits into from
Dec 7, 2020
Merged

feat(alerts): get metric dimensions from blueprint #1490

merged 2 commits into from
Dec 7, 2020

Conversation

roleyfoley
Copy link
Contributor

Description

Adds support for explicit alert metric dimensions defined as part of settings or solution configuration

Motivation and Context

When monitoring systems its common to create your own metrics based on business data which are stored in your monitoring system. This allows you to generate alarms on system infrastructure and business related events. Currently our alert support would only allow for defining metric dimensions based on component resources. As a result of this you couldn't create alerts based on business metrics which don't map to resources

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

RossMurr4y
RossMurr4y previously approved these changes Dec 4, 2020
Copy link
Contributor

@RossMurr4y RossMurr4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one typo to fix up but otherwise happy

@RossMurr4y RossMurr4y merged commit a58bd30 into hamlet-io:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants