Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dind hostname and image details #1503

Merged
merged 1 commit into from
Dec 18, 2020
Merged

fix: dind hostname and image details #1503

merged 1 commit into from
Dec 18, 2020

Conversation

roleyfoley
Copy link
Contributor

Description

Minor fixes to the dind extension following testing

  • Ensures the hostname doesn't contain _ characters which aren't supported
  • Sets that attributes for the dind images

Motivation and Context

The image configuration in solution was removes and replaced with image sourcing the hostname is from the migration to extensions

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley roleyfoley merged commit d36e8ca into hamlet-io:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant