Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert type updates #1520

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix: revert type updates #1520

merged 1 commit into from
Jan 27, 2021

Conversation

roleyfoley
Copy link
Contributor

Description

Some minor changes to revert Type configuration on properties which weren't part of the getCompositeObject type updates in #1514

Motivation and Context

The Type properties in this PR are not used during getCompositeObject processing so should still be kept as the singular Type to maintain compatibility with their usage

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley roleyfoley requested a review from a team January 22, 2021 22:22
@RossMurr4y RossMurr4y merged commit 7f2065e into hamlet-io:master Jan 27, 2021
@roleyfoley roleyfoley deleted the fix-type-updates branch January 27, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants