Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add raw ids for occurrence details #1539

Merged
merged 1 commit into from
Feb 10, 2021
Merged

feat: add raw ids for occurrence details #1539

merged 1 commit into from
Feb 10, 2021

Conversation

roleyfoley
Copy link
Contributor

Description

Adds the Raw Id field for Version and Instance which uses the details from the CMDB or the default value.

Motivation and Context

This is useful for user facing output that reads these files. in the CMDB when we have "default" as the instance or version Id its replaced with an empty string. This makes naming and output in deployment easier. But harder to align the whats in the CMDB with query commands

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley
feat: add raw ids for occurrence details
28a8e9d 
Adds the Raw Id field for Version and Instance. This is useful for user
facing output that reads these files. in the CMDB when we have "default"
as the instance or version Id its replaced with an empty string. This
makes naming and output in deployment easier. But harder to align the
whats in the CMDB with query commands
@roleyfoley roleyfoley requested a review from a team February 8, 2021 00:44
@roleyfoley roleyfoley mentioned this pull request Feb 8, 2021
Merged
7 tasks
@RossMurr4y RossMurr4y merged commit 3f75f01 into hamlet-io:master Feb 10, 2021
@roleyfoley roleyfoley deleted the raw-details-occurrence branch February 10, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossMurr4y RossMurr4y RossMurr4y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roleyfoley @RossMurr4y