Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isolate testing to only include local code #1594

Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix: isolate testing to only include local code #1594

merged 1 commit into from
Mar 24, 2021

Conversation

roleyfoley
Copy link
Contributor

Description

Removes the aws and azure providers from the mock schema generation
test

Motivation and Context

This removes external dependecies on the testing where they aren't required. Changes which are required in plugin repos generally depend on changes in the engine repo. So this essentially creates a dependency loop when changes have been implemented especially around refactors

How Has This Been Tested?

Will test in PR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

Removes the aws and azure providers from the mock schema generation
test

This removes external dependecies on the testing where they aren't
required
@roleyfoley roleyfoley requested a review from a team March 24, 2021 00:31
@RossMurr4y RossMurr4y merged commit 6944564 into hamlet-io:master Mar 24, 2021
@roleyfoley roleyfoley deleted the fix-test-isolation-schemas branch March 24, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants