fix: use loaded providers as definitive providers #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have 2 ways of defining the providers used in a solution the command line options using the -p flag and the CMDB approach which defines the plugins to load which also act as providers This loaded providers are based on what is found in the plguins along with the command line options used. This moves to using the loader input list of providers instead of the command line options
1 task
RossMurr4y
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
Uses the loaded providers as the definitive list of providers that the engine is using for a given pass.
Motivation and Context
We currently have 2 ways of defining the providers used in a solution the command line options using the -p flag and the CMDB approach which defines the plugins to load which also act as providers
This loaded providers are based on what is found in the plugins along with the command line options used. This ensures that the providers loaded through the CMDB are included in processing of entrances, and other functions within in the engine
How Has This Been Tested?
Tested locally
Followup Actions