feat(linkref): initial implementation #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml019
force-pushed
the
feat-named-links
branch
4 times, most recently
from
89bb493
to
03981c7
Compare
Initial support for linkRefs. The previous requirement for the `Tier` and `Component` attributes to be mandatory on a link has been removed as a linkRef can be used by itself. A compensating check for these attributes has been added after `LinkRef` processing is complete.
ml019
force-pushed
the
feat-named-links
branch
from
03981c7
to
85ede20
Compare
roleyfoley
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
Initial implementation of
linkRefs.The actual implementation logic was quite straight forward. It uses recursive logic so nested linkRefs is supported, with detection of circular dependencies included.
A subset of layers currently support the
linkRefsattribute but adding other simply requires the attribute being added to the layer definition and the layer included in the appropriate place in the layer priority order.Motivation and Context
Part of ADR-0007 implementation.
Also a useful way for modules to expose link based functionality without the consumer needing to know the internal details.
How Has This Been Tested?
Related Changes
Prerequisite PRs:
Dependent PRs:
Consumer Actions: