Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a correspondent component #1793

Merged
merged 2 commits into from
Sep 11, 2021

Conversation

kshychko
Copy link
Contributor

@kshychko kshychko commented Sep 8, 2021

Intent of Change

  • New feature (non-breaking change which adds functionality)

Description

Adds the definition for a correspondent component such as AWS Pinpoint

Motivation and Context

This allows creating a component for marketing communication such as push, email or SMS notifications

How Has This Been Tested?

Schema generation testing

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

Consumer Actions:

  • None

"Names" : "Profiles",
"Children" : [
{
"Names" : "Logging",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look this is used at the moment, might be worth removing the profile configuration for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profiles attribute has been removed.

providers/shared/components/firewall/id.ftl Show resolved Hide resolved
@roleyfoley roleyfoley merged commit 05880ea into hamlet-io:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants