Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stackoutput generation and image upload runbooks #2075

Merged
merged 3 commits into from
Dec 13, 2022
Merged

fix: stackoutput generation and image upload runbooks #2075

merged 3 commits into from
Dec 13, 2022

Conversation

roleyfoley
Copy link
Contributor

Intent of Change

  • Bug fix (non-breaking change which fixes an issue)

Description

  • Not sure how but the stackoutput generation entrance seems to have been partially removed.
  • Adds the output process back in to generate stack output files in the engine
  • Adds the resolved inputs for runbooks into the context of steps
  • Fixes how a components image is looked up when pushing images via runbook

Motivation and Context

Added as a collection of fixes found when testing out the image push method for docker containers using the runbook method

How Has This Been Tested?

Tested locally

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

@roleyfoley roleyfoley requested a review from a team December 8, 2022 00:39
RossMurr4y
RossMurr4y previously approved these changes Dec 8, 2022
Copy link
Contributor

@RossMurr4y RossMurr4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will leave to another reviewer to merge as my freemarker is a little rusty!

- Not sure how but the stackoutput generation entrance seems to have
been partially removed.
- Adds the output process back in to generate stack output files in the
engine
- Adds the resolved inputs for runbooks into the context of steps
- Fixes how a components image is looked up when pushing images
via runbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants