fix: don't list disabled suboccurrences #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating an occurrence list, don't include suboccurrences that are disabled. Any component processing should perform an equivalent check but at present the suboccurrence still appears in the list. The same doesn't happen to occurrences since the general flow logic completely excludes any occurrence that is disabled.
roleyfoley
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
When generating an occurrence list, don't include sub-occurrences that are disabled. Any component processing should perform an equivalent check but at present the sub-occurrence still appears in the list.
Motivation and Context
The same doesn't happen to occurrences since the general flow logic completely excludes any occurrence that is disabled.
this fix ensures the behaviour is the same for occurrences or sub-occurrences.
How Has This Been Tested?
Local cli execution.
Related Changes
Prerequisite PRs:
Dependent PRs:
Consumer Actions: