Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline extension into duckdb R package #78

Closed
krlmlr opened this issue Apr 24, 2024 · 3 comments · Fixed by duckdb/duckdb-r#144
Closed

Inline extension into duckdb R package #78

krlmlr opened this issue Apr 24, 2024 · 3 comments · Fixed by duckdb/duckdb-r#144

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Apr 24, 2024

Should we organize the development in a way that the relevant files from this repo can be copied into the duckdb-r repo and this extension becomes bundled with the R package?

Reasons:

  • R (and perhaps even duckplyr) might be the only user ever for this extension
  • duckplyr can look at the duckdb version to detect the capabilities of the extension (otherwise we'd need separate versioning for the extension)
  • fewer things can go wrong with downloading and installing the extension

What are the downsides?

@romainfrancois
Copy link
Collaborator

Or does the extension belong in the duckdb-r repo so that it's always there ?

@krlmlr
Copy link
Collaborator Author

krlmlr commented Apr 26, 2024

@hannes: Do you see downsides in including the rfuns extension into the R package? Who can help with the technical aspects of bundling the extension into the same shared library?

@krlmlr
Copy link
Collaborator Author

krlmlr commented Apr 26, 2024

Hannes and I agreed to include it, for now, it's fine if the development happens in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants