Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate redundant references to Vertex #1643

Closed
hannobraun opened this issue Mar 3, 2023 · 0 comments · Fixed by #1644
Closed

Consolidate redundant references to Vertex #1643

hannobraun opened this issue Mar 3, 2023 · 0 comments · Fixed by #1644
Assignees
@hannobraun
Labels
topic: core Issues relating to core geometry, operations, algorithms type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

(This issue is part of a larger cleanup effort. See #1589.)

Edges in the Fornjot kernel are represented using two types: HalfEdge, which is a directed edge in local (surface) coordinates, and GlobalEdge, which represents the global identity of an edge, and might match up with multiple local HalfEdges that are coincident in global (3D) space.

Both HalfEdge and GlobalEdge reference Vertex. I believe this redundancy can be removed, by removing the Vertex references from GlobalEdge. I don't think they are used by any code that couldn't just get the same references from HalfEdge.
@hannobraun hannobraun added type: development Work to ease development or maintenance, without direct effect on features or bugs topic: core Issues relating to core geometry, operations, algorithms labels Mar 3, 2023
@hannobraun hannobraun self-assigned this Mar 3, 2023
This was referenced Mar 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannobraun hannobraun

Labels
topic: core Issues relating to core geometry, operations, algorithms type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant references to Vertex from GlobalEdge hannobraun/fornjot
1 participant
@hannobraun