Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use any available vsync present mode #1035

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Use any available vsync present mode #1035

merged 3 commits into from
Sep 2, 2022

Conversation

hannobraun
Copy link
Owner

See commit messages for more details.

Close #1034

Previously, any choice of `wgpu::PresentMode` had fallback options. This
is no longer the case in wgpu's most recent version, which can lead to
hardware-dependent failures.

With this change, we're choosing one of the new auto modes, which has
fallback options, restoring something close to the previous behavior.
This brings the style used here in line with all the other code in the
Fornjot codebase.
@hannobraun hannobraun enabled auto-merge September 2, 2022 15:06
@hannobraun hannobraun merged commit 3941fa9 into main Sep 2, 2022
@hannobraun hannobraun deleted the present branch September 2, 2022 15:09
@hannobraun hannobraun changed the title Use any availably vsync present mode Use any available vsync present mode Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fj-app can crash because wgpu doesn't fall back PresentMode to Fifo anymore
1 participant