Define face orientation by the winding of its exterior cycle #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the required `clone` operation explicit.
This is preparation for defining face orientation not by its surface's coordinate system, but by the winding of its exterior cycle.
Instead of just assuming a right-handed coordinate system. This is more preparation for defining face orientation by exterior winding.
This is another building block for defining face orientation by exterior winding.
This commit also includes a big simplification of face/cycle reversal, as the new approach doesn't work with the old, more complex approach. Ignores some more of the sweep tests, for now. I plan to address this later, in a separate pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a drastic simplification of the face and cycle reversal code, and the complete removal of the surface and curve reversal code.
Disables some more sweep tests for the time being, but also puts us in a good position to fix those tests now. I plan to do that in a follow-up commit.
Close #695