Fix blurry egui #1266
Merged
Fix blurry egui #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
previously approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Thank you, @erenoku, this is awesome! I had already searched for something like this, but somehow I've missed it.
Your discovery inspired me to search again, and it turns out that egui-winit has a similar method, and calling that with the right value fixes the input too! I've pushed some additional commits to do that.
While I was at it, I also moved the call to set_pixels_per_point to the update method. This won't make a difference in most cases, but it doesn't seem to hurt and seems more robust.
Thanks again! Always nice to get a second set of eyes on these kinds of things. It's so easy to miss things, when you're working by yourself most of the time.
hannobraun
force-pushed
the
fix_blurry_egui
branch
from
bd97c1d to
1bfc0d5
Compare
This value changing during the runtime of the program is probably a rare edge case, but still, it's worth to support. In any case, doing it this way doesn't seem to hurt.
hannobraun
force-pushed
the
fix_blurry_egui
branch
from
1bfc0d5 to
5b579b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The egui context created here: https://github.com/hannobraun/Fornjot/blob/8c423093840ac7bb99b56533cb8b5804d43a3836/crates/fj-viewer/src/gui.rs#L52 for some reason didn't have the right pixels_per_point ratio so I explicitly set this ratio with the value I got from winit. This solved the blurriness but unfortunately the mouse input is still offseted.