Start extracting new builder API from partial object API #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be hard to support them going forward, and they're not used anyway.
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into some minor trouble with the builder API while working on the validation infrastructure for #1162, so I figured I'd try to solve some of its problems before trying to layer on some more hacks. This pull request starts the process of locking down the partial object API, reducing it to a minimal core, and moving any convenience functionality out of it into a new builder API.
This is the execution of an idea from #1249. I like it so far, as it relieves some pressure on the partial object API, making it simpler, and creating a clearer boundary between essential and non-essential code. I haven't attacked any of the really nasty code yet, so it's hard to say right now how much of a help this will be in solving the larger problem.