Turn the "--models" CLI option into an argument #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopackiw
commented
Nov 7, 2022
| @@ -1,9 +1,9 @@ | |||
| # The default path that models are loaded from. If the `--model` argument is a | |||
| # The default path that models are loaded from. If the `model` argument is a | |||
There was a problem hiding this comment.
One question to consider: should we uppercase any names of CLI arguments used in the documentation (as it is formatted now in help)?
There was a problem hiding this comment.
Good point! Yes, I think we should.
(Still going to merge this as-is though. This is not critical and can always be done in a follow-up PR.)
hannobraun
approved these changes
Nov 8, 2022
| @@ -1,9 +1,9 @@ | |||
| # The default path that models are loaded from. If the `--model` argument is a | |||
| # The default path that models are loaded from. If the `model` argument is a | |||
There was a problem hiding this comment.
Good point! Yes, I think we should.
(Still going to merge this as-is though. This is not critical and can always be done in a follow-up PR.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
--modelflag in the CLI in favour of an optionalmodelargument.Tested locally on custom inputs & examples from the documentation - no regression found.
Closes #1272