Prevent potential floating-point accuracy issues in triangulation #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new form might be a bit easier to read, and the duplication is minimal. It also makes it a bit easier to add more targeted output during debugging.
Due to floating-point accuracy issues, the conversion from 2D point back into 3D points can result in 3D points that are slightly different than the original points. This could lead to a triangle mesh that doesn't fit together around face boundaries. This change sidesteps that potential issue, by using the previously stored original 3D point instead of doing the conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds infrastructure to track the origin 3D points that surface points are converted from, making it possible to remove any conversions that could potentially introduce accuracy problems. See #78 for a wider context and discussion of the issue.
This infrastructure is added in the first few commits. Then follows a whole lot of refactoring, with the pay-off in the second-to-last commit, when the potentially problematic conversions are removed.