Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty segments & points #1585

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Empty segments & points #1585

merged 5 commits into from
Feb 16, 2023

Conversation

tmayoff
Copy link
Contributor

@tmayoff tmayoff commented Feb 13, 2023

No description provided.

@tmayoff tmayoff requested a review from hannobraun as a code owner February 13, 2023 18:29
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tmayoff! Looks good, but CI is failing. Looks like not all doc tests have been updated.

(Hint: You can run something that is close to the full CI build locally, by executing just ci. More info in CONTRIBUTING.md.)

Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes now. Thank you, @tmayoff!

@hannobraun hannobraun merged commit dc43d54 into hannobraun:main Feb 16, 2023
@tmayoff tmayoff deleted the empty_sketch branch February 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants