Require Handle<HalfEdge> in fewer places
#1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't make a whole lot of sense as-is, but it's going to in a few commits.
Re-using an existing `HalfEdge` would be wrong anyway. This also meshes better with some upcoming changes I'm envisioning.
It's getting in the way of what I'm currently working on. Removing it is just easiest. It's not a lot of code, so it can be added back (in an improved form that then won't conflict with anything else, hopefully) when needed.
This will make it possible to simplify the tests, which in turn will enable more refactorings in the builder API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go through a few places in the code and make sure they accept a bare
HalfEdgewhere possible.