Correctly join triangles in BuildShell::tetrahedron
#1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HalfEdge` references `GlobalEdge` (which was returned before), so this is strictly more powerful. It causes some inconvenience, which I'm going to address in future commits.
Move that responsibility to its caller. This makes things a bit more messy for now, but there are two extenuating circumstances: 1. It's necessary. The current approach to joining is insufficient, as it doesn't update the start vertex, and `BuildFace::triangle` doesn't have the information it needs to do it properly. 2. The new, repetitive code in `BuildShell::tetrahedron` can be factored into a new operations API, one specifically for joining.
Previously, the start vertices were ignored when joining, not leading to a correct result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the edges weren't joined correctly, as the vertices were ignored. This came out of my work on #1713.