Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ProcessedShape to fj-interop #809

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

jeevcat
Copy link
Contributor

@jeevcat jeevcat commented Jul 13, 2022

As suggested here: #806 (comment)

Unfortunately, I had to remove the docs link to ShapeProcessor::process, as it is not reachable as a dependency of the fj-interop crate.

@jeevcat jeevcat requested a review from hannobraun as a code owner July 13, 2022 11:31
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jeevcat!

Unfortunately, I had to remove the docs link to ShapeProcessor::process, as it is not reachable as a dependency of the fj-interop crate.

That's an acceptable loss, I think.

@hannobraun hannobraun merged commit ca33fd4 into hannobraun:main Jul 13, 2022
@jeevcat jeevcat deleted the sam/processed-shape-interop branch July 13, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants