Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Vec with DecVeque and remove old statuses as new ones are added #945

Merged
merged 0 commits into from
Aug 12, 2022

Conversation

devanlooches
Copy link
Contributor

No description provided.

Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request, @devanlooches!

The change looks good, but the history is a bit confusing. This pull request contains many commits that have already been merged in earlier pull requests.

Could you to a git rebase main? In general, I prefer rebases over merges in most situations, as that results in a cleaner history that is easier to review.

@devanlooches
Copy link
Contributor Author

I agree sorry. Those commits are as a result of trying to sync the main branch with the fork by just pressing update :(

@devanlooches devanlooches merged commit 79816a2 into hannobraun:main Aug 12, 2022
@devanlooches
Copy link
Contributor Author

oops I just did something stupid I think

@devanlooches
Copy link
Contributor Author

I think I deleted all of my changes. I'm going to remake this pull request cause I think I deleted all of my changes

@hannobraun
Copy link
Owner

Oops, that sucks. Good thing, it wasn't too big of a change.

By the way, in cases like this, you can use git reflog to get your old commits back. In this case, it might be more work to figure out git reflog than it would be to redo the changes 😄

@devanlooches
Copy link
Contributor Author

Cool thanks. I'll know for next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants