Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot is currently not working #1143

Closed
hannobraun opened this issue Sep 27, 2022 · 3 comments
Closed

Dependabot is currently not working #1143

hannobraun opened this issue Sep 27, 2022 · 3 comments
Labels
status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

Rust 1.64.0 comes with support for a new Cargo feature: workspace inheritance. I started using this pretty much immediately (#1132), as it makes the version update that is part of the weekly release much easier, on top of consolidating a lot of redundant metadata.

Unfortunately, Dependabot doesn't support workspace inheritance yet: dependabot/dependabot-core#5315

This means, Dependabot no longer does anything for this repository. It just fails with an error every week. This is unfortunate, but right now I'm not considering rolling the change back. I think the benefits from workspace inheritance outweigh the benefits from Dependabot. I'm opening this issue to document and track the problem. Labeling as https://github.com/hannobraun/Fornjot/labels/status%3A%20blocked.

@hannobraun hannobraun added status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance type: development Work to ease development or maintenance, without direct effect on features or bugs topic: build Anything relating to the build system. labels Sep 27, 2022
@poliorcetics
Copy link

I opened a PR for it dependabot/dependabot-core#5794, it should work but it's not merged yet.

It's probably possible to regenerate the docker container and use it locally to make the necessary changes but I have no idea how to do that

@hannobraun
Copy link
Owner Author

Thank you, @poliorcetics, that's awesome! Hope it gets merged soon!

It's probably possible to regenerate the docker container and use it locally to make the necessary changes but I have no idea how to do that

I have no idea either. I don't know anything about how Dependabot works, and not a lot about Docker either. For now, I'm happy to run cargo update manually every week or so.

@hannobraun
Copy link
Owner Author

Dependabot is active again. Thanks again, @poliorcetics!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Development

No branches or pull requests

2 participants