export-validator
does not support Windows
#1231
Labels
help wanted
Extra attention is needed
topic: build
Anything relating to the build system.
type: feature
New features and improvements to existing features
export-validator
is an application in this repository that uses the Fornjot app to export all models in themodels/
directory to 3MF files, and to validate the correctness of those 3MF files (usinglib3mf
). This is extremely valuable, as it catches a lot of bugs as part of our extended test suite. Specifically,export-validator
is run on every CI build, and can be run locally viajust build
.lib3mf
is a C++ library, which makes the whole setup a bit problematic. I figured it would be easiest to just use the pre-compiled binaries from their SDK. This works for Linux and macOS, but I failed to get this to work for Windows, meaningexport-validator
doesn't run on Windows at all. This is a problem in two ways:just build
orcargo run -p export-validator
locally, which limits their ability to test their changes without submitting a pull request and running a CI build.For these reasons, it would be great if
export-validator
supported Windows too. In principle, this would involve the following steps:libs/
directory under the correct names, so they can be found when linking.export-validator
'sbuild.rs
so everything works.export-validator
in the Windows CI build, by removing the conditional that prevents it from running.I tried to do this, but I just couldn't get it to work. I managed to link to the DLL, but I couldn't make it so that the DLL would then be found at load-time (i.e. when
export-validator
runs). Here is my aborted attempt: #1230I would really appreciate some help with this. I don't have Windows, don't know a whole lot about it, and testing this only via CI builds is a pain in any case. Labeling as https://github.com/hannobraun/Fornjot/labels/help%20wanted.
The text was updated successfully, but these errors were encountered: