Bug in terminal_equity.set_call_matrix

[NikolaosBouas]

For streets 2 and 3 next_round boards ( local next_round_boards = card_tools:get_last_round_boards(board);) is a 2D Tensor containing all the possible boards given a set of board cards.

When you later call handle_blocking_cards in get inner_call_matrix you pass this 2D Tensor as an argument.

Inside handle_blocking_cards you use this 2D array to get the possible hand indexes , which I think is wrong as card_tools:get_possible_hand_indexes expects only one set of board cards.

[happypepper]

Thank you for creating this issue. This is indeed a bug, but I believe it will not affect the quality of the solutions. Inside evaluator.lua, M:evaluate_fast at line 137, the impossible hands are masked. Then inside terminal_equity.lua line 102, the possible_mask is created appropriately.

Would be grateful though if someone could compare results with fixing this bug and without, just to confirm.

[NikolaosBouas]

Ok! Would a solution similar to the one used in leduc implementation be wrong? Specifically , calling get last_round_call_matrix for every possible last round board and then calculating an average over the results.
Also, I am having trouble understanding what kind of information the texas_lookup matrix, which is used in your solution , contains. Could you maybe explain it?

[happypepper]

It would work but wouldn't be fast enough practically so I batched it in my implementation. Theres probably an even faster way to do it.
The texas_lookup table is used for evaluating hand ranks. It's the same as the handranks.dat in this repo: https://github.com/christophschmalhofer/poker/tree/master/XPokerEval/XPokerEval.TwoPlusTwo