From 87fd1dfedf8fc87d7e5edd11896a8efd760b9a68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Sat, 6 Apr 2019 12:37:23 -0300 Subject: [PATCH] Sync Request.Continue tests (#1058) --- lib/PuppeteerSharp.Tests/NetworkTests/RequestContinueTests.cs | 4 ++-- lib/PuppeteerSharp/Request.cs | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) mode change 100755 => 100644 lib/PuppeteerSharp/Request.cs diff --git a/lib/PuppeteerSharp.Tests/NetworkTests/RequestContinueTests.cs b/lib/PuppeteerSharp.Tests/NetworkTests/RequestContinueTests.cs index 108b52843..c6c5ccbf5 100644 --- a/lib/PuppeteerSharp.Tests/NetworkTests/RequestContinueTests.cs +++ b/lib/PuppeteerSharp.Tests/NetworkTests/RequestContinueTests.cs @@ -96,7 +96,7 @@ public async Task ShouldAmendPostData() await e.Request.ContinueAsync(new Payload { Method = HttpMethod.Post, - PostData = "FooBar" + PostData = "doggo" }); }; var requestTask = Server.WaitForRequest("/sleep.zzz", async request => @@ -112,7 +112,7 @@ await Task.WhenAll( Page.GoToAsync(TestConstants.ServerUrl + "/sleep.zzz") ); - Assert.Equal("FooBar", await requestTask.Result); + Assert.Equal("doggo", await requestTask.Result); } } } \ No newline at end of file diff --git a/lib/PuppeteerSharp/Request.cs b/lib/PuppeteerSharp/Request.cs old mode 100755 new mode 100644 index 1ef9626bf..e1e0388a5 --- a/lib/PuppeteerSharp/Request.cs +++ b/lib/PuppeteerSharp/Request.cs @@ -148,6 +148,7 @@ internal Request( /// /// Continues request with optional request overrides. To use this, request interception should be enabled with . Exception is immediately thrown if the request interception is not enabled. + /// If the URL is set it won't perform a redirect. The request will be silently forwarded to the new url. For example, the address bar will show the original url. /// /// Optional request overwrites. /// Task