Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCE vulnerability with System.Text.Encodings.Web@4.0.2 through a sample project #1927

Closed
jorbraken opened this issue Apr 5, 2022 · 2 comments

Comments

@jorbraken
Copy link
Contributor

Description

PuppeteerSharp currently introduces an RCE vulnerability with System.Text.Encodings.Web@4.0.2.0 through a sample project here, and it's throwing off Snyk scanning thinking that's an actual vulnerability... Wondering if that could be upgraded to match a fixed version as listed on that Snyk link?

Complete minimal example reproducing the issue

  • Nothing to reproduce, this is just a vulnerability that's throwing off scanners.

Expected behavior: Vulnerable package System.Text.Encodings.Web@4.0.2.0 throws off scanner

[What you expect to happen]

Actual behavior: Scanner not to go off with that vulnerability

[What actually happens]

Versions

  • Which version of PuppeteerSharp are you using? 6.2.0
  • Which .NET runtime and version are you targeting? .NET framework 4.6.1 and .NET Standard 2.0

Additional Information

N/A

@kblok
Copy link
Member

kblok commented Apr 5, 2022

It makes sense. PRs are welcome :)

@jorbraken
Copy link
Contributor Author

Just dug a little deeper and it seems like it is being used by the Puppeteer itself...
PuppeteerSharp@6.2.0 › Microsoft.AspNetCore.WebUtilities@2.0.2 › System.Text.Encodings.Web@4.4.0

And Microsoft.AspNetCore.WebUtilities is being used directly here

I'll try to collab with a PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants