Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support more than just .exe files on Windows #7

Closed
jokeyrhyme opened this issue Mar 2, 2018 · 4 comments
Closed

support more than just .exe files on Windows #7

jokeyrhyme opened this issue Mar 2, 2018 · 4 comments

Comments

@jokeyrhyme
Copy link

Hi, great library, very handy!

I've noticed that it doesn't find .bat, .cmd, or .com files on Windows

There are quite a lot of executable file extensions on Windows, and my specific use case requires finding .cmd files
@jokeyrhyme
Copy link
Author

Hmmm, might be related to this rust-lang/rust#37519

@harryfei
Copy link
Owner

harryfei commented Mar 4, 2018

I will find a time to implement this. Of course, the PR is also appreciated.

@harryfei
Copy link
Owner

closed by #8 . Thanks @WLBF 's work.

@jokeyrhyme
Copy link
Author

Oh, yay! Thanks! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jokeyrhyme @harryfei