fix: allow liquidMethodMissing to return any supported value type #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harttle
requested changes
May 19, 2024
Co-authored-by: Jun Yang <harttleharttle@gmail.com>
|
@harttle I think I addressed your single piece of feedback, let me know if there's anything else you'd like changed! |
|
@all-contributors please add @admtnnr for code |
|
I've put up a pull request to add @admtnnr! 🎉 |
|
🎉 This PR is included in version 10.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the type of
liquidMethodMissingis too restrictive and only allows returningstringrather than any supported value type. I ran into this issue when trying to return aDropfromliquidMethodMissingto enable dynamic lookups along an entire accessor chain.