Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TokenService (Crypto Service as well) Code Coverage #12987

Open
Tracked by #13145
Neeharika-Sompalli opened this issue Apr 24, 2024 · 1 comment
Open
Tracked by #13145
Assignees
Labels
Epic A body of work that can be broken down into specific tasks. HapiThursday

Comments

@Neeharika-Sompalli
Copy link
Member

Neeharika-Sompalli commented Apr 24, 2024

Add more unit tests to improve code coverage to each class in Token Service

  1. Checked box without issue indicates False negative for coverage where codacy reports 0% coverage but test exists.
  2. Checked box with Issue indicates the associated issue has been addressed.
  3. List items in bold represent classes falling below 80% coverage and targeted for improvement

API


CODEC

  • TokenComparators [83.33 %]

COMPARATOR


STAKING HANDLERS


CUSTOM FEES HANDLERS


TRANSFER HANDLERS


HANDLERS


SCHEMAS


SERDES

  • EntityNumCodec [90 %]

UTIL

  • TokenHandlerHelper [93.75 %]
  • TokenKey [96.3 %]
  • TokenRelListCalculator [97.37 %]

VALIDATORS

  • AllowanceValidator [96.88 %]
  • ApproveAllowanceValidator [100 %]
  • CryptoCreateValidator [83.33 %]
  • CryptoTransferValidator [96.43 %]
  • CustomFeesValidator [98.32 %]
  • DeleteAllowanceValidator [97.3 %]
  • StakingValidator [90.91 %]
  • TokenAttributesValidator [100 %]
  • TokenCreateValidator [100 %]
  • TokenListChecks [68 %] – the only missing line is a private constructor...
  • TokenSupplyChangeOpsValidator [100 %]
  • TokenUpdateValidator [100 %]

BASE PACKAGE

  • BlocklistParser [95.65 %]
  • CryptoSignatureWaiversImpl [100 %]
  • ReadableAccountStoreImpl [94.29 %]
  • ReadableNetworkStakingRewardsStoreImpl [100 %]
  • ReadableNftStoreImpl [100 %]
  • ReadableStakingInfoStoreImpl [100 %]
  • ReadableTokenRelationStoreImpl [100 %]
  • ReadableTokenStoreImpl [100 %]
  • RecordFinalizerBase [80.16 %]
  • Improve TokenServiceImpl code coverage #13164
  • TokenServiceInjectionModule [0 %]
  • WritableAccountStore [90 %]
  • WritableNetworkStakingRewardsStore [100 %]
  • WritableNftStore [96.15 %]
  • WritableStakingInfoStore [100 %]
  • WritableTokenRelationStore [100 %]
  • WritableTokenStore [85 %]

hedera-token-service

@Neeharika-Sompalli Neeharika-Sompalli added the Epic A body of work that can be broken down into specific tasks. label Apr 24, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Apr 24, 2024
@Neeharika-Sompalli Neeharika-Sompalli moved this from 📋 Backlog to 🏃🏻 Sprint Backlog in Services Team Apr 24, 2024
@Neeharika-Sompalli Neeharika-Sompalli moved this from 🏃🏻 Sprint Backlog to Epics in Services Team Apr 24, 2024
@thomas-swirlds-labs
Copy link
Contributor

thomas-swirlds-labs commented May 6, 2024

There are some instances of false negatives for code coverage reported in codacy. See TokenServiceApiImpl as an example where it appears there is no coverage but the test class exists. These classes should be documented and additional coverage should be de-prioritized until we run independent coverage eg. jacoco to support

Screenshot 2024-05-06 at 8 58 01 PM

Screenshot 2024-05-06 at 9 00 43 PM

@netopyr netopyr mentioned this issue May 8, 2024
7 tasks
@povolev15 povolev15 changed the title Improve TokenService Code Coverage Improve TokenService (Crypto Service as well) Code Coverage May 10, 2024
@Neeharika-Sompalli Neeharika-Sompalli added this to the v0.51 milestone May 13, 2024
@netopyr netopyr moved this from Epics to 📋 Backlog in Services Team May 31, 2024
@netopyr netopyr removed this from the v0.51 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic A body of work that can be broken down into specific tasks. HapiThursday
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants