Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module input configuration merge should handle duplicates #984

Open
mkam opened this issue Jul 6, 2022 · 0 comments
Open

Module input configuration merge should handle duplicates #984

mkam opened this issue Jul 6, 2022 · 0 comments

Comments

@mkam
Copy link
Contributor

mkam commented Jul 6, 2022

Description

The merge function for module inputs does not take into account whether there are duplicate module inputs across the two configs that are merging. There should be no duplicates in the merged list of module inputs.

Additional context

  • CTS currently only allows one type of module input per task, but in the future it may allow multiple types, which is why it is stored as a list and not a map.
  • For service module inputs, order should be ignored for the service names list. If the contents of the list are the same, then it is a duplicate.
  • Related bug, which will be solved with a short term fix to remove calling the merge: Module inputs duplicated in state store #979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant