Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash from lock #1145

Merged
merged 1 commit into from
Jul 30, 2015
Merged

Remove trailing slash from lock #1145

merged 1 commit into from
Jul 30, 2015

Conversation

jrgarcia
Copy link

Lock command will remove trailing slash from path (as it is invalid).
Fixes #1136.

@armon
Copy link
Member

armon commented Jul 30, 2015

@jrgarcia Can you trim the prefix itself so that it fixes both lock and semaphore?

@jrgarcia
Copy link
Author

@armon Sure thing

@armon
Copy link
Member

armon commented Jul 30, 2015

@jrgarcia Can you move it to line 103? The issue is that this is in setupLock which means the bug affects setupSemaphore. Moving it into main fixes it for both cases (e.g. -n > 1)

@jrgarcia
Copy link
Author

@armon Gotcha, I understand what you meant by that now. Thanks!

Lock command will remove trailing slash from path (as it is invalid).
Fixes #1136.
armon added a commit that referenced this pull request Jul 30, 2015
@armon armon merged commit 6b4af30 into hashicorp:master Jul 30, 2015
@armon
Copy link
Member

armon commented Jul 30, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants