Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry including host in the metric name #1241

Closed
scalp42 opened this issue Sep 14, 2015 · 4 comments · Fixed by #1284
Closed

Telemetry including host in the metric name #1241

scalp42 opened this issue Sep 14, 2015 · 4 comments · Fixed by #1284
Assignees
Labels
type/enhancement Proposed improvement or new feature

Comments

@scalp42
Copy link
Contributor

scalp42 commented Sep 14, 2015

Hi folks,

I noticed that some of the metrics include the consul host:

consul.consul-i-8de39448.runtime.total_gc_pause_ns
consul.consul-i-8de39448.runtime.num_goroutines

vs

consul.consul.catalog.deregister
consul.consul.fsm.kvs.lock

Is there a way to not have Consul include the host in the metric (which makes it act as a different metric, later instead of former) ?

This way we dont have to rely on extracting the source host from the metricic using regexes.

@slackpad
Copy link
Contributor

Hi @scalp42 it doesn't look like that's exposed via any Consul configuration right now. Unless that gets added, you'd have to make a mod here and build Consul:

https://github.com/hashicorp/consul/blob/master/command/agent/command.go#L572

@scalp42
Copy link
Contributor Author

scalp42 commented Sep 15, 2015

That's a bummer, the source should not be in the metric name (only a few of them have the metric name in it).

@nbrownus
Copy link
Contributor

nbrownus commented Oct 7, 2015

It's an artifact of how the telemetry library works. It would probably be trivial to port the fix for this from vault

hashicorp/vault#419

@scalp42
Copy link
Contributor Author

scalp42 commented Oct 8, 2015

Having the hostname in the metric kill us and it ends up duplicating a shit ton of metrics (vs datadog where you would pay per host for example).

@slackpad any chance we can see @nbrownus ported to consul as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants