Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TCP checks #134

Closed
armon opened this issue May 6, 2014 · 6 comments
Closed

Support TCP checks #134

armon opened this issue May 6, 2014 · 6 comments
Labels
type/enhancement Proposed improvement or new feature

Comments

@armon
Copy link
Member

armon commented May 6, 2014

For high volume HTTP checks, we can avoid fork/exec and do the TCP check in process

@armon
Copy link
Member Author

armon commented May 21, 2014

On second thought, its better to push this externally. Reduces complexity.

@armon armon closed this as completed May 21, 2014
@blalor
Copy link
Contributor

blalor commented May 22, 2014

Can you clarify?

@armon
Copy link
Member Author

armon commented May 22, 2014

I think its simple enough to rely on standard unix commands like nc instead of building that into the core.

@mitchellh
Copy link
Contributor

And to perhaps address the original issue, we've been bouncing ideas for long-running processes to avoid the fork/exec cost for thousands of services. Is this what you were thinking @armon?

@armon
Copy link
Member Author

armon commented May 22, 2014

Yeah #132 is open for that exactly

@josephholsten
Copy link
Contributor

Seems like the push-style checks are provided by the API endpoints /v1/agent/check/{status}/{checkId}. And hey, HTTP is TCP! Is there anything else required for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

4 participants