-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web UI should display service tags #165
Comments
It's my understanding that tags aren't necessarily consistent at the service level. That is, a service on 2 different nodes may have different tags, thus the Web UI would need to "resolve" this conflict, which isn't really ideal. @armon may have thoughts on a solution for this. |
When you select a service it shows the nodes running that service. each one could show the tags that apply to it... |
Yea, from that view it's certainly possible, will mark as a to-do. |
Just deployed the new UI, the new tags are nice but kinda confusing. Since tags are set on a per-service-per-node basis but are displayed on a per-node basis. For example lets say you have a DB server and it has two databases deployed to it. One is called serviceA and has the "master" tag, the other is serviceB and has the "slave" tag. The current way of displaying tags will cause the node to show serviceA and serviceB with tags "master" and "slave". There is no way to tell which is which. |
i'm pulling down latest and building so i can see this in action and maybe contribute a PR... |
@tarrant Agreed, I kind of got it in there as a stub for now, still working out tags for the 0.3 release @andrewwatson Would be great to see a PR if you're able! |
ok, i've never worked with ember before and I can kinda wrap my head around it but i'm not sure i'll be able to knock this out as fast i had hoped! |
I have the changes to index.html, that turned out to be pretty easy. I'm just styling it now. |
Fixed in 25db24e |
Currently all you see is the node name, service name and any check names.
The tag list should be included.
The text was updated successfully, but these errors were encountered: