Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI should display service tags #165

Closed
keyneston opened this issue May 21, 2014 · 9 comments
Closed

Web UI should display service tags #165

keyneston opened this issue May 21, 2014 · 9 comments
Labels
type/enhancement Proposed improvement or new feature

Comments

@keyneston
Copy link

Currently all you see is the node name, service name and any check names.

The tag list should be included.

@pearkes
Copy link
Contributor

pearkes commented Jun 2, 2014

It's my understanding that tags aren't necessarily consistent at the service level. That is, a service on 2 different nodes may have different tags, thus the Web UI would need to "resolve" this conflict, which isn't really ideal.

@armon may have thoughts on a solution for this.

@andrewwatson
Copy link
Contributor

When you select a service it shows the nodes running that service. each one could show the tags that apply to it...

@pearkes
Copy link
Contributor

pearkes commented Jun 2, 2014

Yea, from that view it's certainly possible, will mark as a to-do.

@keyneston
Copy link
Author

Just deployed the new UI, the new tags are nice but kinda confusing.

Since tags are set on a per-service-per-node basis but are displayed on a per-node basis. For example lets say you have a DB server and it has two databases deployed to it. One is called serviceA and has the "master" tag, the other is serviceB and has the "slave" tag. The current way of displaying tags will cause the node to show serviceA and serviceB with tags "master" and "slave". There is no way to tell which is which.

@andrewwatson
Copy link
Contributor

i'm pulling down latest and building so i can see this in action and maybe contribute a PR...

@pearkes
Copy link
Contributor

pearkes commented Jun 6, 2014

@tarrant Agreed, I kind of got it in there as a stub for now, still working out tags for the 0.3 release

@andrewwatson Would be great to see a PR if you're able!

@andrewwatson
Copy link
Contributor

ok, i've never worked with ember before and I can kinda wrap my head around it but i'm not sure i'll be able to knock this out as fast i had hoped!

@andrewwatson
Copy link
Contributor

I have the changes to index.html, that turned out to be pretty easy. I'm just styling it now.

@pearkes
Copy link
Contributor

pearkes commented Jun 11, 2014

Fixed in 25db24e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants