Adds support for prepared query templates. #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
force-pushed
the
f-query-templates
branch
2 times, most recently
from
2c46c34 to
3f33f70
Compare
slackpad
force-pushed
the
f-query-templates
branch
from
e29604f to
b7f4037
Compare
slackpad
force-pushed
the
f-query-templates
branch
2 times, most recently
from
27eebc5 to
4ec826d
Compare
|
Here are the benchmarks with the latest version of everything: The small render should be pretty typical of normal users, and 40 us seems pretty reasonable. |
|
|
||
| var ret structs.PreparedQueries | ||
| for wrapped := queries.Next(); wrapped != nil; wrapped = queries.Next() { | ||
| ret = append(ret, toPreparedQuery(wrapped)) |
There was a problem hiding this comment.
Any reason to not just wrapped.(*queryWrapper).PreparedQuery? You already handle the nil check before we get here it looks like.
slackpad
force-pushed
the
f-query-templates
branch
from
1548588 to
ddf703d
Compare
added 17 commits
March 7, 2016 10:45
This removes some unused dependencies that I know we plan to re-add later, but this makes for a clean `godep save` for now.
…as well as improved iradix tree.
slackpad
force-pushed
the
f-query-templates
branch
from
37bd28f to
1cad6b9
Compare
| parse := func(path string, v reflect.Value) error { | ||
| tree, err := hil.Parse(v.String()) | ||
| if err != nil { | ||
| return fmt.Errorf("Bad format '%s' in Service%s: %s", v.String(), path, err) |
There was a problem hiding this comment.
Does this render correctly without a space after Service?
There was a problem hiding this comment.
Yeah - this is a little cheesy but all paths have a leading "." so this looks like Service.Foo.
|
Code LGTM! 👍 |
slackpad
added a commit
that referenced
this pull request
Mar 7, 2016
Adds support for prepared query templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review.
/cc @ryanuber and @sean-