Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/agent: Google Compute Engine host discovery #2570

Merged
merged 7 commits into from
Jan 12, 2017
Merged

command/agent: Google Compute Engine host discovery #2570

merged 7 commits into from
Jan 12, 2017

Conversation

vancluever
Copy link
Contributor

@vancluever vancluever commented Dec 5, 2016

This PR adds several command-line and config options that facilitate host discovery through Google Compute Engine (GCE), much like the recently added EC2 host discovery options. This should assist with bootstrapping and joining servers within GCE when non-static addresses are used, such as when using managed instance groups.

Documentation has also been added. It should be noted that if running from within a GCE instance, the only option that should be necessary is -retry-join-gce-tag-value.

@vancluever vancluever changed the title command/agent: Google Compute Engine host discovery [WIP] command/agent: Google Compute Engine host discovery Dec 6, 2016
@vancluever
Copy link
Contributor Author

WIPing this as looks like using the command off the command line is not working - will update soon!

This commit adds several command-line and config options that facilitate
host discovery through Google Compute Engine (GCE), much like the
recently added EC2 host discovery options. This should assist with
bootstrapping and joining servers within GCE when non-static addresses
are used, such as when using managed instance groups.

Documentation has also been added. It should be noted that if running
from within a GCE instance, the only option that should be necessary is
-retry-join-gce-tag-value.
Add Google API and related dependencies for GCE discovery.
@vancluever vancluever changed the title [WIP] command/agent: Google Compute Engine host discovery command/agent: Google Compute Engine host discovery Dec 7, 2016
@vancluever
Copy link
Contributor Author

WIP removed - fixed the formatting on the help text and ensured that GCE discovery was actually detected in the same way that EC2 is (ie: adding the presence of the tag value to the same ec2Enabled clause).

@slackpad slackpad added this to the 0.7.3 milestone Dec 19, 2016
@kyhavlov kyhavlov merged commit 4e87e5f into hashicorp:master Jan 12, 2017
@kyhavlov
Copy link
Contributor

Thanks for the PR, @vancluever! This is a nice piece of functionality to have alongside the EC2 join stuff.

@vancluever
Copy link
Contributor Author

No prob and thanks for the merge @kyhavlov!

@magiconair
Copy link
Contributor

@vancluever I've got a question regarding your PR since I'm moving your code to https://github.com/hashicorp/go-discover. You name the override parameter for the project project-name but during auto-discovery you lookup the project-id. Using the project name also fails for me but it works fine when I use the project ID. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants