Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node ID robustification #2700

Closed
slackpad opened this issue Feb 1, 2017 · 1 comment
Closed

Node ID robustification #2700

slackpad opened this issue Feb 1, 2017 · 1 comment
Milestone

Comments

@slackpad
Copy link
Contributor

slackpad commented Feb 1, 2017

We need to add some more checks for node IDs in order to make them more robust and avoid nodes being able to steal away an ID from another node.

  1. Enforce that node IDs are either empty or proper UUIDs in /v1/catalog/register. The UUID field index will ensure this, but the feedback to the users won't be friendly, so it's better to validate it early.

  2. When a node is being registered, look for an existing node by that ID. If no node exists, then add the new node. If an existing node is found, reject the change unless the node name is the same as well. If we don't do this, registrations can steal away the ID from another node. You'll need to deregister the other node first.

@slackpad slackpad added this to the 0.8.0 milestone Feb 1, 2017
@slackpad
Copy link
Contributor Author

Closed in #2832.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant