Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI/API endpoints for removing peer by ID #2847

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Add CLI/API endpoints for removing peer by ID #2847

merged 1 commit into from
Mar 30, 2017

Conversation

kyhavlov
Copy link
Contributor

No description provided.

slackpad
slackpad approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@slackpad slackpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

consul/operator_endpoint.go Outdated
@@ -126,6 +137,73 @@ REMOVE:
return nil
}

// RaftRemovePeerByID is used to kick a stale peer (one that it in the Raft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one that "is" in

@kyhavlov kyhavlov merged commit 9ff4322 into master Mar 30, 2017
@kyhavlov kyhavlov deleted the remove-peer-by-id branch March 30, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slackpad slackpad slackpad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyhavlov @slackpad