Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update complete version to v1.1 #3646

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

posener
Copy link
Contributor

@posener posener commented Nov 4, 2017

Update posener/complete to revision=v1.1.

Changes in bash completion:

  • Autocomplete flags after equal sign (-a=)
  • The implementation of a completion function does not have to filter results anymore.

I left only one occurrence of posener/complete in the vendor/vendor.json, there was an occurrence for
each package individually.

@preetapan
Copy link
Contributor

@posener Yes, we changed the format. You can run make vendorfmt to fix the formatting and update this PR.

Also make dev should have done this for you if you ran that locally when testing your changes.

@preetapan
Copy link
Contributor

Also, could you provide some details on what improvements/changes we can expect to see with the updated version, so that we can test for it and update Consul's changelog appropriately?

Update posener/complete to revision=v1.1.
Leave only once occurrence of posener/complete in vendor, there was an occurrence for
each package individualy.

The formatting of vendor/vendor.json has changed after using
the command "govendor fetch github.com/posener/complete@=v1.1"
@posener
Copy link
Contributor Author

posener commented Nov 8, 2017

Hi @preetapan
Thanks!
Updated the commit.
Updated the PR message with the change details.

@slackpad slackpad merged commit 26c0c2a into hashicorp:master Dec 15, 2017
@slackpad
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants